Trouble finding new instrument

grillparzer · May 7, 2025, 4:29am

Hello -
I am using PP 0.76.1 on a Mac Sequoia 15.4.1, Java 21.0.5+11-LTS. I have defined 417 securities into my portfolio, all of them getting their price informantion from yahoo.

Hickup: I tried to add a new security, ticker 1171.HK , name “Yankuang enegy”, ISIN code CNE1000004Q8 into my list of securities. I click the “+” symbol, and type “1171.HK” into the search box. I am shown the error message:

Yahoo Finance: 429 Too Many Requests → https://query2.finance.yahoo.com/v1/finance/lookup?formatted=true&lang=de-DE&region=DE&query=1171.hk&type=all&count=25&start=0&corsDomain=de.finance.yahoo.com

The same happens if I type “Yankuang” or give the ISIN-code. So, I then choose the option “Empty Instrument”, give currency as HKD and symbol as 1171.HK & name as “Yankuang Energy Co”. The security is created, but without price data.

I right click this security in the list of securities, and choose “Quotes”. The first two selections, “Update quotes online” and “Debug: show server response” are greyed out. I choose the third selection: “Configure online update”. A new dialog opens with “Historical quotes” tab open, where the provider is stated as “No automatic quote download”. I change that to “yahoo finance”, and PP downloads its quotes immediately. I close this screen, and now I can choose also the previously greyed out “Update quotes online”.

So: adding a new security has gotten now rather complicated, as I need to add the price information provider yahoo manually later. I am rather certain that this has been working without this manual step before. I even can’t define the price information provider in the new “Add new investment instrument” -dialog => what’s wrong?

OnkelDok · May 7, 2025, 5:00am

The fix from yesterday (☀ New & Noteworthy - #77 by AndreasB) seems to be only fix fetching quotes for existing/added instrument. So it seems the fix has to be also applied to the segment where quotes and information are loaded for the security-search function.

I assume @AndreasB will fix that soon.

EDIT:
Maybe these are the relevant code segments:

github.com/portfolio-performance/portfolio

name.abuchen.portfolio/src/name/abuchen/portfolio/online/impl/YahooSearchProvider.java

master


      
          String html = new WebAccess("query2.finance.yahoo.com", "/v1/finance/lookup") //
                          .addParameter("formatted", "true") //
                          .addParameter("lang", "de-DE").addParameter("region", "DE") //
                          .addParameter("query", query) //
                          .addParameter("type", "all") //
                          .addParameter("count", "25") //
                          .addParameter("start", "0") //
                          .addParameter("corsDomain", "de.finance.yahoo.com") //
                          .get();

github.com/portfolio-performance/portfolio

name.abuchen.portfolio/src/name/abuchen/portfolio/online/impl/YahooSymbolSearch.java

master


      
          var html = new WebAccess("query2.finance.yahoo.com", "/v1/finance/search") //
                          .addParameter("q", query) //
                          .addParameter("region", "DE") //
                          .addParameter("lang", "de-DE") //
                          .addParameter("quotesCount", "6") //
                          .addParameter("newsCount", "0") //
                          .addParameter("enableFuzzyQuery", "false") //
                          .addParameter("quotesQueryId", "tss_match_phrase_query") //
                          .addParameter("multiQuoteQueryId", "multi_quote_single_token_query") //
                          .addParameter("newsQueryId", "news_cie_vespa") //
                          .addParameter("enableCb", "false") //
                          .addParameter("enableNavLinks", "false") //
                          .addParameter("enableEnhancedTrivialQuery", "false") //
                          .get();

Rafa · May 7, 2025, 5:24am

Ragher than fixing plenty of source code sections, their is only one line who chane everything.

github.com/portfolio-performance/portfolio

name.abuchen.portfolio/src/name/abuchen/portfolio/util/OnlineHelper.java

master

package name.abuchen.portfolio.util;

public final class OnlineHelper
{

    @SuppressWarnings("nls")
    public static String getUserAgent()
    {
        return "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.3.1 Safari/605.1.15";
    }

}

github.com/portfolio-performance/portfolio

name.abuchen.portfolio/src/name/abuchen/portfolio/util/WebAccess.java

12eb257e9


      
                          .setResponseTimeout(Timeout.ofSeconds(20)) //
                          .setCookieSpec(StandardCookieSpec.STRICT) //
                          .build();
          
          public static final ConnectionConfig defaultConnectionConfig = ConnectionConfig.custom()
                          .setConnectTimeout(Timeout.ofSeconds(5)) //
                          .build();
          
          private final URIBuilder builder;
          private List<Header> headers = new ArrayList<>();
          private String userAgent = OnlineHelper.getUserAgent();
          
          public WebAccess(String host, String path)
          {
              this.builder = new URIBuilder();
              this.builder.setScheme("https"); //$NON-NLS-1$
              this.builder.setHost(Objects.requireNonNull(host).trim());
              this.builder.setPath(Objects.requireNonNull(path).trim());
          }
          
          public WebAccess(String url) throws URISyntaxException

github.com/portfolio-performance/portfolio

name.abuchen.portfolio/src/name/abuchen/portfolio/util/WebAccess.java

12eb257e9


      
          {
              try
              {
                  var connectionManager = new PoolingHttpClientConnectionManager();
                  connectionManager.setDefaultConnectionConfig(defaultConnectionConfig);
          
                  CloseableHttpClient client = HttpClientBuilder.create() //
                                  .setConnectionManager(connectionManager) //
                                  .setDefaultRequestConfig(defaultRequestConfig) //
                                  .setDefaultHeaders(this.headers) //
                                  .setUserAgent(this.userAgent) //
                                  .useSystemProperties() //
                                  .build();
          
                  URI uri = builder.build();
                  HttpUriRequestBase request = function.create(uri);
          
                  return client.execute(request, new CustomResponseHandler(uri.toString()));
              }
              catch (HttpResponseException e)
              {

OnkelDok · May 7, 2025, 5:31am

Thats correct, but I assume @AndreasB doesn’t wanted to change the user agent for all web accesses (e.g. HTMLTableQuoteFeed and GenericJSONQuoteFeed), but only for the yahoo ones. Because currently only yahoo had problems with this central user agent.
But maybe I’m wrong.